Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47739 )
Change subject: soc/intel/xeon_sp: Remove superfluous printk ......................................................................
soc/intel/xeon_sp: Remove superfluous printk
This debug output is not very useful. If CONFIG_BOOTBLOCK_CONSOLE is enabled there will already be something else printed on the console before this.
Change-Id: I7c6013805497604bb6a42ed4f9fdc594a73c28f1 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/47739 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Rocky Phagura --- M src/soc/intel/xeon_sp/bootblock.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved Rocky Phagura: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/bootblock.c b/src/soc/intel/xeon_sp/bootblock.c index baf5ab5..0b04f03 100644 --- a/src/soc/intel/xeon_sp/bootblock.c +++ b/src/soc/intel/xeon_sp/bootblock.c @@ -62,9 +62,6 @@
void bootblock_soc_init(void) { - if (CONFIG(BOOTBLOCK_CONSOLE)) - printk(BIOS_DEBUG, "FSP TempRamInit successful...\n"); - if (assembly_timestamp > bootblock_timestamp) printk(BIOS_WARNING, "Invalid initial timestamp detected\n");