Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47640 )
Change subject: drivers/i2c: Add a driver for Semtech SX9324 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip... File src/drivers/i2c/sx9324/chip.h:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/chip... PS2, Line 12: /* ACPI _HID */ : const char *hid;
Not required. This is not used by the driver.
I see bindings for 3 HIDs in 5.4 (drivers/iio/proximity/sx932x.c): STH9320, STH9321, STH9324
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... File src/drivers/i2c/sx9324/sx9324.c:
https://review.coreboot.org/c/coreboot/+/47640/2/src/drivers/i2c/sx9324/sx93... PS2, Line 75: D%03.3X This is pretty generic; from the datasheet, it will be "D028" almost all of the time 😊 What about a more unique prefix, like "SX" ?