Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60515 )
Change subject: mb/google/corsola: Remove 'corsola' from Kconfig board names ......................................................................
mb/google/corsola: Remove 'corsola' from Kconfig board names
The 'Corsola' (MT8186 Chromebooks) family has two reference designs (Krabby and Kingler) and all real implementations should follow either one of the two. To prevent confusion, we should remove the 'corsola' configuration from Kconfig board names.
BUG=b:210806060 TEST=emerge-corsola coreboot
Signed-off-by: Rex-BC Chen rex-bc.chen@mediatek.com Change-Id: Ib354054e358c0783f6221c2e2a1730b5c6ddba33 Reviewed-on: https://review.coreboot.org/c/coreboot/+/60515 Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Rex-BC Chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 702c3fc..f6be164 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -45,7 +45,6 @@
config MAINBOARD_PART_NUMBER string - default "Corsola" if BOARD_GOOGLE_CORSOLA default "Kingler" if BOARD_GOOGLE_KINGLER default "Krabby" if BOARD_GOOGLE_KRABBY
diff --git a/src/mainboard/google/corsola/Kconfig.name b/src/mainboard/google/corsola/Kconfig.name index 0953220..85cb41e 100644 --- a/src/mainboard/google/corsola/Kconfig.name +++ b/src/mainboard/google/corsola/Kconfig.name @@ -1,9 +1,3 @@ -comment "Corsola" - -config BOARD_GOOGLE_CORSOLA - bool "-> Corsola" - select BOARD_GOOGLE_CORSOLA_COMMON - comment "Kingler"
config BOARD_GOOGLE_KINGLER