Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/treeya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 30: static int sku = -1;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1)
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 32: if (sku == -1)
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id();
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 33: sku = google_chromeec_get_sku_id();
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35214/5/src/mainboard/google/kahlee... PS5, Line 34: return sku;
code indent should use tabs where possible
Done