Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37552 )
Change subject: amdblocks/pci: add common implementation of MMCONF enabling ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/amd_pci_mmconf.h:
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/in... PS2, Line 17: void enable_pci_mmconf(void); Just put this in amd_pci_util.h.
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/pc... File src/soc/amd/common/block/pci/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37552/2/src/soc/amd/common/block/pc... PS2, Line 6: ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_PCI_MMCONF) += amd_pci_mmconf.c IMHO we do not need the guard, it is still behind SOC_AMD_COMMON :
all-y += pci_mmconf.c