[coreboot-gerrit] Change in coreboot[master]: lenovo/g505s: properly program the IRQ tables

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47852 )

Change subject: lenovo/g505s: properly program the IRQ tables
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47852/4/src/mainboard/lenovo/g505s/... 
File src/mainboard/lenovo/g505s/mptable.c:

https://review.coreboot.org/c/coreboot/+/47852/4/src/mainboard/lenovo/g505s/... 
PS4, Line 76: /* PIC IRQ routine */
            : 	for (byte = 0x0; byte < sizeof(picr_data_ptr); byte++) {
            : 		outb(byte, 0xC00);
            : 		outb(mainboard_picr_data[byte], 0xC01);
            : 	}
            : 
            : 	/* APIC IRQ routine */
            : 	for (byte = 0x0; byte < sizeof(intr_data_ptr); byte++) {
            : 		outb(byte | 0x80, 0xC00);
            : 		outb(mainboard_intr_data[byte], 0xC01);
            : 	}
It looks like this is also done in the southbridge code, so it could be fully removed from the mainboard code.