Paul Menzel has posted comments on this change by Brandon Weeks. ( https://review.coreboot.org/c/coreboot/+/81595?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADL-4L-V1.0 board
......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/cwwk/adl/Kconfig:
https://review.coreboot.org/c/coreboot/+/81595/comment/de1fb58d_f3b5f2dc?usp... :
PS10, Line 9: select HAVE_ACPI_RESUME
Ack
Just a note, that `/sys/kernel/debug/pmc_core/slp_s0_residency_usec` stays 0 on my Dell XPS 13 9360 with Intel Kaby Lake (i7-7500U). It changes on a Dell XPS 9370 with Intel Kaby Lake R (i5-8350U). But as you use Alder Lake, it might be unrelated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81595?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice9174d95c10afc6a22ddd15fb3be4fa38d329be
Gerrit-Change-Number: 81595
Gerrit-PatchSet: 13
Gerrit-Owner: Brandon Weeks
bweeks@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Federico Amedeo Izzo
federico@izzo.pro
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Joel Linn
jl_coreboot@conductive.de
Gerrit-CC: Matthew Garrett
mjgarrett59@googlemail.com
Gerrit-Comment-Date: Mon, 27 May 2024 12:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brandon Weeks
bweeks@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com