Attention is currently required from: Arthur Heymans, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67099 )
Change subject: drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67099/comment/7729d4cf_3df527cf PS3, Line 12: devietree devicetree
File src/drivers/i2c/rv3028c7/chip.h:
https://review.coreboot.org/c/coreboot/+/67099/comment/09a8994f_eeafc202 PS3, Line 2: Add guards around header file?
https://review.coreboot.org/c/coreboot/+/67099/comment/6433b40e_40edb4bd PS3, Line 28: CARGE_VIA_3K CHARGE_? Same below.
https://review.coreboot.org/c/coreboot/+/67099/comment/88113048_f794616a PS3, Line 38: /* User year to set */ /* User year to set (2-digit) */
https://review.coreboot.org/c/coreboot/+/67099/comment/77c28363_86d000e0 PS3, Line 41: cap_cahrge cap_charge?
File src/drivers/i2c/rv3028c7/rv3028c7.c:
https://review.coreboot.org/c/coreboot/+/67099/comment/a6ce518f_c40dee34 PS3, Line 22: } while ((status & EE_BUSY_BIT) && !stopwatch_expired(&sw)); Add a 1ms delay here so this time can be used elsewhere if needed?
See thread_yield functions.