Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34728 )
Change subject: soc/intel/common: Implement MAINBOARD_POWER_STATE_PREVIOUS ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34728/3/src/soc/intel/apollolake/pm... File src/soc/intel/apollolake/pmc.c:
https://review.coreboot.org/c/coreboot/+/34728/3/src/soc/intel/apollolake/pm... PS3, Line 125: PCI_DEV_INVALID
Please add a comment here as to why you're using PCI_DEV_INVALID
I think that would go way too far. FSP is hiding PCI devices from coreboot. So the device is invalid. We cannot comment every single line that is affected by an FSP deficiency. Otherwise we'd have much more comments than code.