Attention is currently required from: Dtrain Hsu, Henry Sun, Tim Wawrzynczak, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54057 )
Change subject: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CONFIG ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
A question for fw_config. […]
Tim - Yes, we do! I will raise a bug to see if I can get some help on it from kernel team.
Dtrain - No. But, ACPI nodes will be generated based on device being on/off which can be controlled which fw_config. Thus, it provides a way to trigger certain ACPI _ON/_OFF routines without having to add special fw_config checks.
File src/mainboard/google/dedede/variants/cret/variant.c:
https://review.coreboot.org/c/coreboot/+/54057/comment/307bf076_1d160304 PS3, Line 18: Once the FW_CONFIG is provisioned, I know it is not the most ideal thing, but is there any harm in calling `power_off_lte_module()` unconditionally when going down into S5? For devices with LTE module, it will ensure proper power off sequence. For devices without LTE module, it will just toggle some pads and then go down into S5 after which we fall into G3 in 10 seconds. I don't think there should be any power leakage issues as well.