Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39232 )
Change subject: soc/intel/tigerlake: Enable Hybride storage mode ......................................................................
Patch Set 6:
(4 comments)
Why is this done by the FSP and not in coreboot?
https://review.coreboot.org/c/coreboot/+/39232/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39232/6//COMMIT_MSG@9 PS6, Line 9: storage(optane) Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/39232/6//COMMIT_MSG@12 PS6, Line 12: By enabling Hybrid Storage mode in FSP, FSP will detect Hybrid storage Please add one blank line above to separate paragraphs.
https://review.coreboot.org/c/coreboot/+/39232/6//COMMIT_MSG@12 PS6, Line 12: FSP What FSP component is that?
https://review.coreboot.org/c/coreboot/+/39232/6/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39232/6/src/soc/intel/tigerlake/chi... PS6, Line 266: /* Hybrid storage mode enable(1)/disable(0) */ Please add a space before the (.