HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use DEFAUL BARs_ADDRESS symbols ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig@525 PS14, Line 525: .bars yes the order matter. I need to declare symbols before the default entries. So if I put that line after "src/northbridge/*/*/Kconfig", Kconfig tools like menuconfig will see for example' DEFAULT_MCHBAR_ADDRESS' defined at intel/gm45/Kconfig :
here is a "screenshot":
Mainboard > Search (DEFAULT_MCHBAR_ADDRESS) ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
┌─────────────────────────────────────────────────────────────────────────────────── Search Results ────────────────────────────────────────────────────────────────────────────────────┐ │ Symbol: DEFAULT_MCHBAR_ADDRESS [=0xfed14000] │ │ Type : hex │ │ Defined at src/northbridge/intel/gm45/Kconfig:17 │ │ Depends on: NORTHBRIDGE_INTEL_GM45 [=n]
so even if I rename it as 'Kconfig.common' or just 'Kconfig', I definitely need to "source" it before 'northbridge/intel/*/Kconfig'
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... File src/northbridge/intel/common/Kconfig.bars:
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... PS14, Line 3: DEFAULT_
I used `FIXED_` as prefix in CB:43037 and it went in, so we could use it here too.
Ack