Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 )
Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@10 PS1, Line 10: This requires soc/intel target to : explicitly set this in the SOC dir
I see the sanity, but don't follow conclusion, why is it require by […]
It's a bit like the overuse of __weak in soc/intel to make stuff build without being correct. Requiring things to de explicitly done in the soc dir could avoid that? I'll try to better state that.
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@12 PS1, Line 12: wrong
How can it be wrong? does the FSP binary depend on a specific location?
The integration guide recommends (I looked at kabylake) against using non default values and if FSP-T is used it needs to match what is programmed in that UPD, so I think it sufficiently safe to say there are values that should not be tried out.