Attention is currently required from: Bill XIE, Martin L Roth, Matt DeVillier, Stefan Reinauer, Arthur Heymans.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65920 )
Change subject: payloads/edk2: Add a recipe to build a Universal Payload Entry point
......................................................................
Patch Set 34:
(3 comments)
File payloads/external/edk2/Makefile:
https://review.coreboot.org/c/coreboot/+/65920/comment/7240ca07_cdbc651d
PS32, Line 195: prep
nit: indent an extra level to show that this is a prerequisite.
Done
https://review.coreboot.org/c/coreboot/+/65920/comment/c0d5061d_37613bed
PS32, Line 207: ;
remove ';' - not needed.
Done
https://review.coreboot.org/c/coreboot/+/65920/comment/7ffc246c_490ece06
PS32, Line 207:
unindent?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I187d703a5d7bfd8efc25409bf79ef8ab0e92ae6c
Gerrit-Change-Number: 65920
Gerrit-PatchSet: 34
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 04 Sep 2022 20:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment