Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28640 )
Change subject: mb/clevo/n130wu: Add mainboard ......................................................................
Patch Set 70:
(2 comments)
https://review.coreboot.org/#/c/28640/69/src/mainboard/clevo/n130wu/Kconfig File src/mainboard/clevo/n130wu/Kconfig:
https://review.coreboot.org/#/c/28640/69/src/mainboard/clevo/n130wu/Kconfig@... PS69, Line 29: if BOARD_CLEVO_N130WU || BOARD_CLEVO_N131WU This isn't needed here or in any of the cases below because you're already inside the top level 'if'. If another variant is added that needs differentiation, put the 'if' on that, and put it above this default.
If you don't plan on adding any other variants, you can get rid of this block and the devicetree block below and just put the default devicetree in the root mainboard directory.
https://review.coreboot.org/#/c/28640/69/src/mainboard/clevo/n130wu/Kconfig@... PS69, Line 36: config DEVICETREE : string : default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
if you intend to add variants you might want to look into overridetree
Last time I tried the override devicetree, I felt like it was too fragile for my use. It didn't always produce the output I wanted or expected. It does work, but when anyone uses it, I'd be very careful to verify that they get the correct output in static.c.