Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39018 )
Change subject: ec/google/chromeec: Introduce SKU_ID helpers ......................................................................
Patch Set 6:
(2 comments)
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/Kcon... PS4, Line 103: # set to 0xff for LEGACY : config EC_GOOGLE_CHROMEEC_SKUID_MAX : hex : default 0x7fffffff
Nothing is using fw_config in userspace yet. So, that shouldn't be a problem.
Ack
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... File src/ec/google/chromeec/ec_skuid.c:
https://review.coreboot.org/c/coreboot/+/39018/4/src/ec/google/chromeec/ec_s... PS4, Line 34: google_chromeec_smbios_system_sku
If you rename this smbios_system_sku, then you can avoid this https://review.coreboot. […]
Yes, to get rid of the wrapping indirect, what I was saying is that the the function is named without the googleness in mind in the general code path of arch/x86/smbios.c and wanted to keep it so that it isn't over-fitted to our needs.
Do you mind if we can treat that as a separate bug and scope those changes to that? The original bug b/149348474 already has very large scope runaway. I think these changes already create 90% of the ground work to polishing that off any way.