Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42552 )
Change subject: mb/google/hatch: Make puff and variants share common ec.h
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42552/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/baseboard/include/puff/ec.h:
https://review.coreboot.org/c/coreboot/+/42552/1/src/mainboard/google/hatch/...
PS1, Line 3: VARIANT_EC_H
Does this work?
no, copy-paste error. thx for the catch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13dfe09da5c7a19677b156063bb51a58bc059b93
Gerrit-Change-Number: 42552
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Comment-Date: Fri, 19 Jun 2020 04:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Gerrit-MessageType: comment