Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42313 )
Change subject: tests: Add lib/b64_decode-test test case
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c
File tests/lib/b64_decode-test.c:
https://review.coreboot.org/c/coreboot/+/42313/1/tests/lib/b64_decode-test.c...
PS1, Line 27: /* Provide necessary definition in order to satisfy dependencies. */
Done
Can you please still do this? Who knows when that SPI flash patch is going to move forward, you shouldn't wait for that. Whoever can merge first wins.
I'm okay with doing this in a separate patch but I would like to have that stub concept (or whatever else we decide to do about this recurring boilerplate) to be in place before we start adding a slew of new tests that need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5fe9272e30eaff3d086a95241b3819101089c2b
Gerrit-Change-Number: 42313
Gerrit-PatchSet: 3
Gerrit-Owner: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Jul 2020 23:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anna Karaś
aka@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Jan Dabros
jsd@semihalf.com
Gerrit-MessageType: comment