Attention is currently required from: Arthur Heymans, Jincheng Li, Shuo Liu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81133?usp=email )
Change subject: arch/x86/include/arch: Add feature check macros
......................................................................
Patch Set 7:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/81133/comment/a86509e6_cc57f380 :
PS1, Line 51: CPUID_FEATURE_MCE
This is referenced in GNR codes, but not critical. We can leave this to later.
Please squash with the code that make use of it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81133?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I014c25ced1dbe21f35486f8305b1de7669e932d0
Gerrit-Change-Number: 81133
Gerrit-PatchSet: 7
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 21 Mar 2024 09:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Gerrit-MessageType: comment