10 Feb
2020
10 Feb
'20
4:48 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38780 )
Change subject: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... PS2, Line 46: static int vboot_get_recovery_reason_shared_data(void) Since now this function is used only in one place, should we consider moving the 3-line code into vboot_check_recovery_request()?
--
To view, visit https://review.coreboot.org/c/coreboot/+/38780
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52d17a3c6730be5c04c3c0ae020368d11db6ca3c
Gerrit-Change-Number: 38780
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching kitching@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 10 Feb 2020 03:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment