Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40561 )
Change subject: soc/intel/common: Add downgrade support for CSE Firmware
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40561/12/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/custom_bp.c:
https://review.coreboot.org/c/coreboot/+/40561/12/src/soc/intel/common/block...
PS12, Line 543: /* Check if CSE reports data mismatch error */
No, the comment is for cse_is_rw_dp_valid().
Sorry, with the naming of the next function, why not name it `cse_check_data_mismatch_error`?
The define is has *failure* instead of *mismatch*. The wording should be consistent.
https://review.coreboot.org/c/coreboot/+/40561/12/src/soc/intel/common/block...
PS12, Line 569: return false;
if this function fails, recovery mode is triggered in the error path.
1. Can dead_code() be used here somehow?
2. I still think, an error message needs to be printed, if unreachable code is executed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a3a3036e448e5a743398f6b27e8e62965dbff3c
Gerrit-Change-Number: 40561
Gerrit-PatchSet: 14
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 May 2020 14:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment