2 comments:
File src/soc/intel/common/block/cse/custom_bp.c:
Patch Set #12, Line 543: /* Check if CSE reports data mismatch error */
No, the comment is for cse_is_rw_dp_valid().
Sorry, with the naming of the next function, why not name it `cse_check_data_mismatch_error`?
The define is has *failure* instead of *mismatch*. The wording should be consistent.
Patch Set #12, Line 569: return false;
if this function fails, recovery mode is triggered in the error path.
1. Can dead_code() be used here somehow?
2. I still think, an error message needs to be printed, if unreachable code is executed.
To view, visit change 40561. To unsubscribe, or for help writing mail filters, visit settings.