Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
(5 comments)
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Which gigabyte boards? The GA-H61M-S2PV? The scheme here looks a bit different, though.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
The Gigabyte boards have the name of the first board that was added. If I were to rename them, I thought of "ga-h61m-series" because they all have the H61 PCH.
For these boards, I think the PCH differs, but the socket is constant. So I'd probably use "x11-lga1150-series" or something like that.
Or if you can't find a name that everybody likes, just leave the current name as-is and cut out the bikeshedding :-)
Well, I am not sure what Patrick meant... if he meant Kconfig style I based this on the scheme ga-b75m Gigabyte boards used which do not have a baseboard, too. Further IMHO my Kconfig style here is way more readable as it does not use "if" in every second line but pulls the settings from the variants folder.
What about x11-c236-series?