Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/12/src/security/vboot/common....
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/12/src/security/vboot/common....
PS12, Line 52: struct vb2_context **vboot_ctx_ptr = car_get_var_ptr(&vboot_ctx);
Honestly, I find this harder to follow than the previous version. But might be a matter of taste.
¯_(ツ)_/¯
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051be1e47bf79b15a1689d49a5d4c031e9363dfa
Gerrit-Change-Number: 36300
Gerrit-PatchSet: 12
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 10:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment