Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36067 )
Change subject: mainboard/hatch/Kconfig: Add support for boot with Tianocore payload
......................................................................
Patch Set 5:
Hi Paul Menzel,
I did explore the Kconfig option of PAYLOAD_TIANOCORE and it would still require the Pm timer and legacy 8254 timer to be enabled externally to support Tianocore boot.
It would be difficult to modify the payload config and use it in our SoC code. Hence, we would like to have this BOARD_USES_TIANOCORE Kconfig in our mainboard which would default be set to No and can be selected only when the user needs it.
However, I confirmed that the GBB flags are not required and hence modified the CL.
Kindly have a look.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36067
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42fcf23523889d47f0490fbd662ca6b7587ab548
Gerrit-Change-Number: 36067
Gerrit-PatchSet: 5
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Nov 2019 04:34:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment