Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37263 )
Change subject: mb/google: Add ALIGNED flag to known sections that need alignment ......................................................................
Patch Set 5:
(6 comments)
Turns out that if you really think about it, most of the RW sections are intended to be independently updateable. ;)
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... File src/mainboard/google/auron/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 7: RW_SECTION_A@0x0 0xf0000 { Please also add this for all RW_SECTION_(A/B).
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 18: RW_ELOG(PRESERVE ALIGNED)@0x1f0000 0x4000 nit: Should we maybe change this to allow commas instead? I think this just hasn't come up yet since the two attributes we had before never stood together, but now that we have cases like that I think space-separation looks pretty weird.
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 20: SHARED_DATA@0x0 0x2000 ...and for both of these...
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 23: RW_VPD(PRESERVE)@0x1f8000 0x2000 ...and for all RW_VPD...
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 25: SMMSTORE(PRESERVE)@0x200000 0x40000 ...and probably for SMMSTORE?
https://review.coreboot.org/c/coreboot/+/37263/5/src/mainboard/google/auron/... PS5, Line 26: RW_LEGACY(CBFS)@0x240000 0x1c0000 ...and probably for RW_LEGACY too.