Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34886 )
Change subject: arch/x86: Improve definition of MAYBE_STATIC
......................................................................
Patch Set 1:
Patch Set 1:
src/mainboard/intel/icelake_rvp/board_id.c: MAYBE_STATIC int id = -1;
Need some solution for these.
Got it. OK. Looks like we may have to do zero vs non-zero decorations?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f584058c7ea3a68ef7f38eaf3c9d8daf620828e
Gerrit-Change-Number: 34886
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Aug 2019 15:56:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment