Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35906 )
Change subject: mb/pcengines/apu2: use AGESA 1.0.0.4 with adjusted AGESA header
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35906/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35906/1//COMMIT_MSG@11
PS1, Line 11:
Is this just a precaution or does this fix real problems?
Just a precaution.
https://review.coreboot.org/c/coreboot/+/35906/1/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/Kconfig:
https://review.coreboot.org/c/coreboot/+/35906/1/src/mainboard/pcengines/apu...
PS1, Line 117: AGESA_USE_OLD_HEADER
How about some help section here that describes the problem a little and point to specific commit ha […]
Done
https://review.coreboot.org/c/coreboot/+/35906/1/src/mainboard/pcengines/apu...
PS1, Line 117: config AGESA_USE_OLD_HEADER
Use the version 1_0_0_4 instead of old?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d85ee14e35dae8079e8d552b6530a3867f65876
Gerrit-Change-Number: 35906
Gerrit-PatchSet: 8
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Feb 2020 12:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment