[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Uniformize reading the TPM access register

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45390 )

Change subject: nb/intel/x4x: Uniformize reading the TPM access register
......................................................................

Patch Set 7: Code-Review+1

(1 comment)

Curious, do you have a platform to test on?

https://review.coreboot.org/c/coreboot/+/45390/4/src/northbridge/intel/x4x/r... 
File src/northbridge/intel/x4x/raminit.c:

https://review.coreboot.org/c/coreboot/+/45390/4/src/northbridge/intel/x4x/r... 
PS4, Line 621: 	read8((void *)TPM_BASE_ADDRESS);
> you don't use the information gathered, so this is as useless as before.

Reads can have side effects.