Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36043 )
Change subject: soc/intel/cannonlake: Add gfx.asl file ......................................................................
Patch Set 12:
Patch Set 11:
Patch Set 10:
Patch Set 10:
Patch Set 10:
does this need to be #included somewhere?
I see it included in the last commit now. You could just #include it in northbridge.asl instead of needing to add it to the mainboard ASL.
northbridge or southbridge, should it always be included or based on some config flag?
Probably in northbridge, and it could be included always as it will get ignored if the PCI device doesn't exist.
The southbridge.asl file had other includes with PCI devices so I put it there. If there is a reason to move it to northbridge I will do that.