Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37703 )
Change subject: [WIP] asrock/e350m1: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37703/1/src/mainboard/asrock/e350m1...
File src/mainboard/asrock/e350m1/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37703/1/src/mainboard/asrock/e350m1...
PS1, Line 25: sb_Poweron_Init();
To our current knowledge you can remove this. We call it later in romstage in common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie14db10b6a72e19ac67254ca8f95bcf6ac8af8d3
Gerrit-Change-Number: 37703
Gerrit-PatchSet: 1
Gerrit-Owner: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 13 Dec 2019 13:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment