Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )
Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................
Patch Set 1:
(1 comment)
This will become a little more complicated, see CB:31206.
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig
File src/drivers/intel/wifi/Kconfig:
https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig@12
PS1, Line 12: default y if !SYSTEM_TYPE_LAPTOP
As `NO_INTEL_WIFI` only changes the default above, I'd rather
see this directly in DRIVERS_INTEL_WIFI's default line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Comment-Date: Sun, 03 Feb 2019 17:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment