Change in ...coreboot[master]: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_...

[mikeb mikeb (Code Review)]

Hello Mike Banon,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/c/coreboot/+/31220

to review the following change.


Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................

src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP

Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI
should not be selected by default if the mainboard is not a laptop.

Signed-off-by: Mike Banon <[e-mail]>
Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
---
M src/drivers/intel/wifi/Kconfig
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31220/1

diff --git a/src/drivers/intel/wifi/Kconfig b/src/drivers/intel/wifi/Kconfig
index 4082d7e..8fdd0a3 100644
--- a/src/drivers/intel/wifi/Kconfig
+++ b/src/drivers/intel/wifi/Kconfig
@@ -8,7 +8,9 @@
 
 # Select this for mainboard which is unlikely to have Intel PCI-e WiFi adapter.
 config NO_INTEL_WIFI
-	def_bool n
+	bool
+	default y if !SYSTEM_TYPE_LAPTOP
+	default n
 
 config USE_SAR
 	bool

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-MessageType: newchange

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Patch Set 1:

This change depends on CB:31119 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 16:23:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Patch Set 1:
> Patch Set 1:
>
> This change depends on CB:31119 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option

Sorry I meant CB:31219 - src/drivers/intel/wifi/Kconfig: add NO_INTEL_WIFI option


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 16:25:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 16:41:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: src/drivers/intel/wifi/Kconfig: enable NO_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Patch Set 1:

(1 comment)

This will become a little more complicated, see CB:31206.

https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig 
File src/drivers/intel/wifi/Kconfig:

https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig@12 
PS1, Line 12: 	default y if !SYSTEM_TYPE_LAPTOP
As `NO_INTEL_WIFI` only changes the default above, I'd rather
see this directly in DRIVERS_INTEL_WIFI's default line.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-Comment-Date: Sun, 03 Feb 2019 17:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYP...

[mikeb mikeb (Code Review)]

Hello Patrick Rudolph, HAOUAS Elyes, Mike Banon, build bot (Jenkins), Nico Huber, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/31220

to look at the new patch set (#2).

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................

drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP

Intel PCI-e WiFi adapters are rare outside of laptops. DRIVERS_INTEL_WIFI
should not be selected by default if the mainboard is not a laptop.

Signed-off-by: Mike Banon <[e-mail]>
Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
---
M src/drivers/intel/wifi/Kconfig
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/31220/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYP...

[mikeb mikeb (Code Review)]

mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig 
File src/drivers/intel/wifi/Kconfig:

https://review.coreboot.org/#/c/31220/1/src/drivers/intel/wifi/Kconfig@12 
PS1, Line 12: 	default y if !SYSTEM_TYPE_LAPTOP
> As `NO_INTEL_WIFI` only changes the default above, I'd rather […]
> Great idea! Although I couldn't resolve a merge conflict so I abandoned this change and made a new one, CB:31222 , please take a look

Change in ...coreboot[master]: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYP...

[mikeb mikeb (Code Review)]

mikeb mikeb has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31220 )

Change subject: drivers/intel/wifi/Kconfig: disable DRIVERS_INTEL_WIFI if !SYSTEM_TYPE_LAPTOP
......................................................................


Abandoned

moving to CB:31222
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93a9e8fc9ba92f755524250e6cbcf9d1ba1acbdc
Gerrit-Change-Number: 31220
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: Mike Banon <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: mikeb mikeb <[e-mail]>
Gerrit-MessageType: abandon