Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: soc/mediatek/mt8192: add spmfw loader
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/Kc...
File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/46389/35/src/soc/mediatek/mt8192/Kc...
PS35, Line 49: "The file name of the MediaTek SPM firmware"
You don't need to add this (unless if you want to allow developers overriding that when 'make menu'; but I'd say that's usually a bad idea - this should be changed in Kconfig files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6478b98f426d2f3e0ee919d37d21d909ae8a6371
Gerrit-Change-Number: 46389
Gerrit-PatchSet: 36
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 02:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment