[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Support modification of single Flash Descriptor

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38711 )

Change subject: util/ifdtool: Support modification of single Flash Descriptor
......................................................................

util/ifdtool: Support modification of single Flash Descriptor

Add the capability to update the Flash Descriptor directly instead
of raising a Segmentation Fault. In this way it will be possible to
add a Kconfig options to modify the ifd descriptor at build-time.

Change-Id: Id3db09291af2bd2e759c283e316afd5da1fb4ca7
Signed-off-by: Marcello Sylvester Bauer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38711
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M util/ifdtool/ifdtool.c
1 file changed, 19 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 0b6b210..2bf2f4d 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -1336,11 +1336,18 @@
    		new_extent = new_regions[i].limit;
    }

-	new_extent = next_pow2(new_extent - 1);
-	if (new_extent != size) {
-		printf("The image has changed in size.\n");
-		printf("The old image is %d bytes.\n", size);
-		printf("The new image is %d bytes.\n", new_extent);
+	/* check if the image is actually a Flash Descriptor region */
+	if (size == new_regions[0].size) {
+		printf("The image is a single Flash Descriptor:\n");
+		printf("    Only the descriptor will be modified\n");
+		new_extent = size;
+	} else {
+		new_extent = next_pow2(new_extent - 1);
+		if (new_extent != size) {
+			printf("The image has changed in size.\n");
+			printf("The old image is %d bytes.\n", size);
+			printf("The new image is %d bytes.\n", new_extent);
+		}
    }

/* copy regions to a new image */
@@ -1367,6 +1374,12 @@
    		offset_current = current->size - new->size;
    	}

+		if (size < current->base + offset_current + copy_size) {
+			printf("Skip descriptor %d (%s) (region missing in the old image)\n", i,
+				region_name(i));
+			continue;
+		};
+
    	printf("Copy Descriptor %d (%s) (%d bytes)\n", i,
    			region_name(i), copy_size);
    	printf("   from %08x+%08x:%08x (%10d)\n", current->base,
@@ -1384,6 +1397,7 @@
    if (!frba)
    	exit(EXIT_FAILURE);

+	printf("Modify Flash Descriptor regions\n");
    for (i = 1; i < max_regions; i++)
    	set_region(frba, i, &new_regions[i]);