Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34514 )
Change subject: mb/google/hatch: Enable chipset_lockdown coreboot config for hatch ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34514/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34514/1//COMMIT_MSG@9 PS1, Line 9: lockdown configuration I believe your intent is to enable configuration lockdown by coreboot instead of FSP? What are the different configs that coreboot will be locking down and skipped by FSP? For KBL, I see following UPDs being set to 0 if coreboot is doing the lockdown: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/skylake/chi...
But there is no such change in soc/intel/cannonlake that would take effect for hatch. Don't you need a corresponding change for soc/intel/cannonlake?