Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35345 )
Change subject: mb/google/hatch: override smbios manufacturer name from CBI ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/... PS1, Line 56: smbios_mainboard_manufacturer Some day I think it might make sense to move this to ec/google/chromeec/. For now we can keep it here.
https://review.coreboot.org/c/coreboot/+/35345/1/src/mainboard/google/hatch/... PS1, Line 66: BIOS_ERR I don't think this should be BIOS_ERR. BIOS_INFO maybe? it is not an error if OEM name is not present in CBI. It is an optional field. In fact, is there any value in having this print?