[coreboot-gerrit] [S] Change in coreboot[master]: acpi: Add missing cbfs_unmap()

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Tim Wawrzynczak, Grzegorz Bernacki, Tim Van Patten.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )

Change subject: acpi: Add missing cbfs_unmap()
......................................................................

Patch Set 3:

(1 comment)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/74715/comment/287cc7b9_0bbdf89d 
PS2, Line 1934: 	cbfs_unmap(dsdt_file);
> Your point about better documentation is incredibly valid ;)

Just the documentation for mem_pool library is not sufficient. Any API that uses these mem_pool APIs should also be documented - like cbfs_map/unmap in this case.

A better documentation, if not already available, highlighting the need to unmap CBFS file after usage, order of unmaps and limiting the number of maps to 2 will help with sustaining the allocator in its current form. If those APIs are not used properly, then it will eventually end up hitting the allocator.