18 Jul
2019
18 Jul
'19
8:22 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34382 )
Change subject: WIP: mediatek/mt8183: Add SCP work support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34382/2/src/soc/mediatek/mt8183/scp... File src/soc/mediatek/mt8183/scp.c:
https://review.coreboot.org/c/coreboot/+/34382/2/src/soc/mediatek/mt8183/scp... PS2, Line 66: while (read32(&mt8183_scp->gpr0) != 0xaaaa) { braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/34382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0801eac078aa9d6237142dcd92a3c3e9237a86ee
Gerrit-Change-Number: 34382
Gerrit-PatchSet: 2
Gerrit-Owner: Erin Lo erin.lo@mediatek.com
Gerrit-Reviewer: Erin Lo erin.lo@mediatek.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 18 Jul 2019 05:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment