Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39475 )
Change subject: {soc,drivers}: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table
......................................................................
Patch Set 3:
(1 comment)
Please take another look
https://review.coreboot.org/c/coreboot/+/39475/2/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/ish.asl:
https://review.coreboot.org/c/coreboot/+/39475/2/src/soc/intel/tigerlake/acp...
PS2, Line 4: 2019
Can we really claim 2020 copyright, if this was originally submitted in 2019, and not actually modif […]
After offline discussion with Nick, we have agreed that since this is a pure cherry-pick, the safe thing is to not update the copyright year.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I082c5bdd83a9d9e1a23dbc38b74e5f9752c98c99
Gerrit-Change-Number: 39475
Gerrit-PatchSet: 3
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Thu, 12 Mar 2020 21:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jes Klinke
jbk@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment