Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30935 )
Change subject: console/init: Print log level in coreboot banner
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/30935/1/src/console/init.c
File src/console/init.c:
https://review.coreboot.org/#/c/30935/1/src/console/init.c@87
PS1, Line 87: BIOS_NOTICE
According to the definitions of the log level, that is what should be done right now. […]
I think it's fine to keep it at that level. Once you're not into notices, you probably don't care about the stages either.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82c87ae90cd53fd47458fc6df3ef2c7f238f0f3d
Gerrit-Change-Number: 30935
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 16 Jan 2019 12:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment