Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48222 )
Change subject: drivers/i2c/tpm: Unconditionally allow I2C TPM ACPI node
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48222/4//COMMIT_MSG@20
PS4, Line 20: one having I2C TPM and another having
: I2C TPM
two sub variants both having i2c tpm, what's the problem?
Thanks for pointing this out. I meant one sub-variant using SPI, another using I2C.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9717f6b68afd90fbc294fbbd2a5b8d0c6ee9ae55
Gerrit-Change-Number: 48222
Gerrit-PatchSet: 5
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 07 Dec 2020 17:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment