Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar()
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34808/6/src/cpu/intel/car/romstage....
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/6/src/cpu/intel/car/romstage....
PS6, Line 25: early_mtrrs
This is never referenced directly except in the romstage_main function. […]
Well, it is zero-initialized here, while as local stack variable compiler might think it is not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34808
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0418a2abc74f749203c587b2763c5f8a5960e4f9
Gerrit-Change-Number: 34808
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Aug 2019 12:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment