mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c@276 PS14, Line 276: if (CONFIG(MULTIPLE_VGA_ADAPTERS)) : return current; : /* Write ACPI VFCT only for Discrete VGA. */ : /* TODO: do this also for Integrated VGA. */ : break; : case PCI_CLASS_DISPLAY_OTHER: : if (!CONFIG(MULTIPLE_VGA_ADAPTERS)) : return current; : break;
Getting code upstream is about working on nice and maintainable solutions to problems and getting fe […]
I'm still working on this patch (rebasing when it becomes incompatible with upstream + some minor improvements) and updating a set of scripts at CB:31929 to install it, but of course I am interested in CB:31502 - just didn't feel I have the time/skills to pull it off.
Please tell, how to accomplish this - "to look at the vendor ACPI code to figure out what it does?" I could temporarily install a proprietary UEFI, run a set of commands (what commands?) and share their detailed output, and do any other requests helpful for CB:31502 patch