Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47448 )
Change subject: soc/intel/xeon_sp: Lock down DMI3 PCI registers
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47448/6/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47448/6/src/mainboard/ocp/deltalake...
PS6, Line 66: device pci 07.0 on end
move to next patch
done
https://review.coreboot.org/c/coreboot/+/47448/6/src/soc/intel/xeon_sp/skx/i...
File src/soc/intel/xeon_sp/skx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47448/6/src/soc/intel/xeon_sp/skx/i...
PS6, Line 181: #define ERRINJCON 0x1d8
CPX has an extra \n here
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5637eb8dd7de406b24b92100b68c5fa11c16854
Gerrit-Change-Number: 47448
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 13:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment