Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 42:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/dd875ff3_0887b154 PS42, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/d9d91a8e_2bbc50e0 PS42, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/9aea8d4e_c627679c PS42, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/7d10a9b9_8bb416b3 PS42, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/c77d21ff_c021ab5d PS42, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/9c7addaf_f27fad00 PS42, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/8218a26d_c852ad1f PS42, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/b891e520_aa175fc0 PS42, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/a3502249_9e0d8f1b PS42, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/80a775e0_977968e1 PS42, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/46504379_d1baa048 PS42, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/606c2a4c_65756e35 PS42, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/d8d65bce_2738f58e PS42, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/ac0eab1e_c679acf1 PS42, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/e67f71c6_5d3c8158 PS42, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/1a17c44e_5904f316 PS42, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/32d8d76c_76abbdbc PS42, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/7ddc7fa0_2cc75949 PS42, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/091b8285_6be371a7 PS42, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/41cfa1de_e84ea811 PS42, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/0636b482_5419da9f PS42, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/a5187bbb_203afef2 PS42, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/4cb495ae_96f5841f PS42, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/2bb136b6_b8d77ab4 PS42, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/3850e902_053f11cb PS42, Line 21: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120393): https://review.coreboot.org/c/coreboot/+/49767/comment/a48d163a_eedcbb93 PS42, Line 21: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line