Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37514 )
Change subject: soc/intel/skylake: Add option to control microcode update inclusion
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37514/4/src/soc/intel/skylake/Kconf...
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/37514/4/src/soc/intel/skylake/Kconf...
PS4, Line 301: endif
:
: if !SKYLAKE_SOC_PCH_H
I was wondering why this isn't an "else". […]
As far as I know you are right. We initially tried to use the else here but it didn't work out. If there is a better solution I would like to know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa36c2846b2279a2eb2b61e6c97d6c89d0736f55
Gerrit-Change-Number: 37514
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Dec 2019 14:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment