build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35031 )
Change subject: soc/intel/skylake: Add GPIOs layout for Lewisburg PCH
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/gpio...
File src/soc/intel/skylake/gpio.c:
https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/gpio...
PS12, Line 240: #else
braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/gpio...
PS12, Line 243: # if CONFIG(SKYLAKE_SOC_PCH_H)
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia72c37121fa9616e4ef0ce4acfb36188363c231e
Gerrit-Change-Number: 35031
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Sep 2019 15:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment