Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44549 )
Change subject: memory_info: Rename ddr_frequency to ddr_speed_mts ......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
+Tim and +Karthik as well.
Have you verified all call sites to ensure that they are providing the correct input? i.e. MT/s instead of MHz?
https://review.coreboot.org/c/coreboot/+/44549/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44549/4//COMMIT_MSG@11 PS4, Line 11: 0
we are at 3.0.0, so this should be specified in MHz and not MT/s.
It's a mess. Starting in 3.1 (not 3.0 like I stated) of the spec, this field was retroactively reinterpreted as MT/s because "This maintains backward compatibility with observed DDR implementations prior to this revision, which already reported transfer rate instead of clock speed". So it sounds like this field has always been mislabeled.
Arguably this a bug in dmidecode, and it should interpret this field differently when the version is 3.0 or earlier. Here's the patch that changed the units in dmidecode: https://github.com/mirror/dmidecode/commit/1aef508ce487804fcfd12da9afc5a73cc...