Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34497 )
Change subject: mb/google/drallion: Add new mainboard
......................................................................
Patch Set 8:
Patch Set 8: Code-Review-1
Patch Set 8:
Patch Set 8:
Please add Documentation as well, that answers the following question:
Which flash IC does it use?
Where does the flash reside?
Can you flash in-circuit?
Are there debug headers?
Can you provide a picture of the flash IC?
What was tested and what works/does not?
Patrick, You might want to add the above list to documentation about what you'd like to see for new mainboards that we can point people to. Obviously we can't give out this information right now, but we could create a bug to add this information when the chromebook is released.
Maybe make a template page for new devices?
We could add a field to board_info.txt - Unreleased/Released (date)/No longer for sale. If it's marked as released, we could require documentation.
Sure will add it to the documentation.
Releasing the source code but not giving further details sounds like a lame excuse.
It allows you to release broken, plain wrong and undocumented code that nobody can verify, as you are not able to publicly acknowledge or deny anything.
Giving -1 until it's clear how it was tested and what is actually working.
Thejaswani, can you include a what you have tested in the description?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I541952a4ef337e7277a85f02d25979f12ec075c4
Gerrit-Change-Number: 34497
Gerrit-PatchSet: 8
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: AndreX Andraos
andrex.andraos@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Jul 2019 18:19:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment